adds ReturnAsync extention method that accepts a Func<TResult>

[joeenzminger]

No description provided.

[kzu]

Why not return Task.FromResult(value()) instead?

[joeenzminger]

That works as well (at least it passes the tests). I was just trying to be consistent with the method used in the extension methods that were already there. Not sure if there is an advantage/disadvantage either way.

[joeenzminger]

Looks like Task.FromResult() is probably the "newer" way to go.

http://stackoverflow.com/questions/21256110/task-fromresult-vs-taskcompletionsource-setresult

[tomasaschan]

I had just started implementing this too, when I found this PR :)

I've extended it with implementations for Funcs that take arguments here - they basically just forward to the already existing Returns method, wrapping the result in a Task. That builds on this PR - would you prefer I make a pull request against @joeenzminger's master to get it here, or file a separate PR directly with moq/moq4?

[kzu]

Far better to have a single PR than to have to pick a "winner" 😉

On Fri, Nov 4, 2016, 2:36 AM Tomas Lycken notifications@github.com wrote:

I had just started implementing this too, when I found this PR :)

I've extended it with implementations for Funcs that take arguments here
tomasaschan@27d548d

• they basically just forward to the already existing Returns method,
  wrapping the result in a Task. That builds on this PR - would you prefer
  I make a pull request against @joeenzminger
  https://github.com/joeenzminger's master to get it here, or file a
  separate PR directly with moq/moq4?

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#297 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKW62nfIQhAi4_d_k38ivRB2sd8OTDwks5q6uCBgaJpZM4KcZ7n
.

/kzu from mobile

[tomasaschan]

Done :)

When joeenzminger#1 merges, it should show up here; if you have comments or suggestions for improvement, feel free to raise them there or here.

[kzu]

👍