refactored Interceptor.Intercept to use a set of strategies. . #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was broken in 8 separated strategies
|
Much needed refactoring. It's looking very promising. Thanks for working on this. |
…y when following action need to be executed
|
I added the enum. Test still pass. Maybe you would also rename the strategies: My is sometimes just a guessing, maybe they are not generally understendable. |
kzu
added a commit
that referenced
this pull request
Feb 28, 2013
refactored Interceptor.Intercept to use a set of strategies. .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function was previously a little difficult to figure out due to many ifs and returns. I broken up the function in 8 different strategies, of course not yet perfect, but should be easyier to modify/read.