Added overload to enforce old behavior of exact parameter matching #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this is adding an overload in Protected Mock to enable the old behavior of exact parameter type matching again (see also issue #341). In the tests you can see the scenario in which the new behavior broke existing code. Hope that makes the problem more clear. |
kzu
reviewed
May 24, 2017
UnitTests/ProtectedMockFixture.cs
Outdated
| @@ -751,6 +771,16 @@ protected virtual string DoReturn(string a, string b) | |||
| protected virtual void SameFirstParameter(object a) { } | |||
|
|
|||
| protected virtual void SameFirstParameter(object a, object b) { } | |||
|
|
|||
| protected virtual FooBase OverloadWithDerived(MyBase myBase) | |||
There was a problem hiding this comment.
It's kinda confusing that the method is called WithDerived yet it receives a base type. How about naming it simply Overloaded or the like?
There was a problem hiding this comment.
Your totally right. Updated the method name accordingly. But a better name than "overloaded" also did not come into my mind. Finding good names is harder than coding ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.