Fix mocking of non-virtual methods via interface #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 0e3eaf3 broke the ability of mocking a non-virtual method if it is set up and called via an interface (`mock.As<TInterface>()`). This commit restores that feature.
In the preceding commit, some logic was added that might both remove an item from the `ImplementedInterfaces` list and decrement another variable (`InternallyImplementedInterfaceCount`). Both should ideally happen as an atomic operation. It turns out that the removal is actually irrelevant, and the method `Mock.As<TInterface>` can be simplified somewhat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #381 (specifically, commit 0e3eaf3) broke the ability of mocking a non-virtual method if it is set up and called via an interface (
mock.As<TInterface>()). This commit restores that feature.This should fix #383.