Allow setting up null return values using Mock.Of
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moq currently doesn't allow setting up a method to return `null` via `Mock.Of`. At current, such a setup seems irrelevant as `null` is often the default value that doesn't have to be set up explicitly. However, if we want to allow custom default value providers in the future, meaning that `null` might no longer be the default value in all cases, it should be possible to set up `null` explicitly.
Setting up an explicit `null` return value in `Mock.Of` does not work because a `null` constant in an expression tree is by default of type `object`, which leads to a type mismatch when Moq uses that constant to build a new binary expression to do a != comparison. Therefore make sure to assign a compatible type to `null` const exprs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #337.