Clean up build process #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
build
branch
2 times, most recently
from
8750613
to
c1e4e71
Compare
The `Common` submodule has been abandoned back in commit fdc94ea.
The separate .NET Framework 4.5 and .NET Standard 1.3 projects are merged into a single multi-targeting `.csproj`. Note that this breaks GitLink, which isn't too much of a problem, as the `.pdb` files aren't currently included in the Moq NuGet package anyway, but this will have to be addressed in a later commit.
stakx
force-pushed
the
build
branch
3 times, most recently
from
cb1077f
to
f7f0fc6
Compare
stakx
force-pushed
the
build
branch
3 times, most recently
from
c19af28
to
9417cc3
Compare
GitLink claims to support the new `.csproj` file, but apparently it does not. It also doesn't support the new portable PDB format, and the current build process wouldn't end up using the PDB files anyway because so far verification that GitLink produces desired PDBs hasn't happened. We're switching to SourceLink here which supports the new `.csproj` format and portable PDBs. Integration into the build process also couldn't be easier.
If the release notes are duplicated in two places (in the `.nuspec`, and in the actual `ReleaseNotes.md`), it's very easy to forget that they must be kept in sync. Therefore, replace the release notes in the `.nuspec` file with a hyperlink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.