Make setups for inaccessible internal members fail fast by throwing an exception #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For two reasons:
1. We will need to have it available inside the `Mock` class.
2. We don't need several factories, a single one is enough, so
having it in a generic class means that more factories will get
instantiated than necessary. This can be avoided by the move
from `Mock<T>` to `Mock`.
stakx
force-pushed
the
invisible-internals
branch
2 times, most recently
from
e3d6119
to
642150f
Compare
stakx
changed the title
stakx
force-pushed
the
invisible-internals
branch
from
642150f
to
1a75ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moq currently does not complain when an attempt is made to
Setupan internal method that the proxy won't be able to intercept because the[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]attribute for DynamicProxy is missing. The setup appears to succeed, yet won't take effect when the mock is used.These commits add checks that verify whether methods that are being set up are accessible to DynamicProxy; if they are not,
Setupet al. throw an exception (i.e. fail fast).This closes #178.