Validate delegates passed to Returns
more strictly
#520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minimal validation logic for delegates passed to
Returns
:While it would be desirable from a technical standpoint, parameter types do not get checked for assignment compatibility due to two possibly widespread practices:
Callback uses a by-value callback parameter while method being set up has a by-ref-parameter:
Callback uses a subtype and setup uses a matcher to ensure runtime value conversion will always succeed:
While those are possibly not the cleanest programming practices (from a purely technical point of view), many people might find them useful in practice. Allowing them means that parameter type validation becomes pretty much pointless.
This closes #445.