Improve consistency of type names related to method interception #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, rename `ICallInterceptor` to `IInterceptor` for consistency.
Second, merge `Interceptor` into `Mock` by letting `Mock` implement
`IInterceptor` directly. This has two advantages:
1. We no longer need the double composition / wrapping of intercep-
tors currently found in `CastleProxyFactory`.
2. Interception can change a mock's state. Having `Mock` perform the
interception itself means that we get a little closer to the mock
changing its own state, instead of having it changed by another,
separate object.
Interception "strategy" suggests that only one of several gets chosen and executed. In truth, all "strategies" are executed. Each one deals with a specific aspect of a mock method invocation, so rename the type to reflect this better. All source files directly related to method interception are put in a separate sub-folder `Interception` and renamed for better consistency.
stakx
force-pushed
the
invocation-interception
branch
from
3c8f89a
to
1e51370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a refactoring of type names surrounding mock method interception. This is mostly to improve naming consistency across the code base, but also to better express the intent of some types.
A few interface types are additionally turned into abstract base classes, allowing us to apply some small-scale optimizations and code cleanup.