Move state (fields) from Mock
into Mock<T>
#540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock state and initialization is currently split across both
Mock
andMock<T>
. This is not ideal for at least three reasons:It is difficult to get an idea how much state a mock object really carries.
It can be hard to understand control flow (e. g. with mock object initialization), which might bounce back and forth between methods defined in both
Mock
andMock<T>
.It's relatively easy to introduce
As<TInterface>
-related bugs by directly referencing backing fields instead of their corresponding properties.As<TInterface>
mocks do not use their own backing fields (which remain completely uninitialized), but instead delegate all properties to the "owner" mock's. Therefore, forAs<TInterface>
mocks to work correctly, code should always reference the properties, and never the backing fields. Moving the fields away fromMock
(where most logic sits) helps with enforcing this.