Refactor ImplementedInterfaces contraption
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
implemented-interfaces
branch
from
15ddeaf
to
9feadd8
Compare
`ImplementedInterfaces` together with `InternallyImplementedInterface- Count` contains three logically semi-separate sets of interface types: 1. interface types inherited from the mocked type 2. `IMocked<T>` 3. additional interface types requested through `As<TInterface>()` This commit pries these three things apart: (1) is turned into a `InheritedInterfaces` property, which is implemented using a static backing field, (2) is directly referenced where required, and (3) is turned into a `AdditionalInterfaces` property. This results in simpler code and reduced memory consumption.
stakx
force-pushed
the
implemented-interfaces
branch
from
9feadd8
to
e618ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImplementedInterfacestogether withInternallyImplementedInterfaceCountcontains three logically semi-separate sets of interface types:IMocked<T>As<TInterface>()Combining these three into a single collection results in some rather convoluted code.
This commit pries these three things apart: (1) is turned into a
InheritedInterfacesproperty, which is implemented using a static backing field, (2) is directly referenced where required, and (3) is turned into aAdditionalInterfacesproperty.This results in simpler code and reduced memory consumption.