VerifyNoOtherCalls: Fix bugs with Mock.Of<T>
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocks created with `Mock.Of<T>` can already have recorded invocations. This can make `VerifyNoOtherCalls` fail unexpectedly, as these tests demonstrate.
stakx
commented
Dec 3, 2017
| @@ -108,7 +108,7 @@ public static class Mocks | |||
| [Obsolete("Moved to Mock.Of<T>, as it's a single one, so no reason to be on Mocks.", true)] | |||
| public static T OneOf<T>(Expression<Func<T, bool>> specification) where T : class | |||
| { | |||
| return CreateMockQuery<T>().First<T>(specification); | |||
| return Mock.Of<T>(specification); | |||
There was a problem hiding this comment.
Delegate to Mock.Of<T> (as claimed by the [Obsolete] attribute's message) so we don't need to duplicate the hack here.
stakx
commented
Dec 3, 2017
| @@ -94,7 +94,7 @@ public static class Mocks | |||
| [Obsolete("Moved to Mock.Of<T>, as it's a single one, so no reason to be on Mocks.", true)] | |||
| public static T OneOf<T>() where T : class | |||
| { | |||
| return CreateMockQuery<T>().First<T>(); | |||
| return Mock.Of<T>(); | |||
There was a problem hiding this comment.
Delegate to Mock.Of<T> (as claimed by the [Obsolete] attribute's message).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that mocks created with
Mock.Of<T>initially have no recorded invocations.Due to the way
Mock.Of<T>is currently implemented, mocks created using this method might already have recorded invocations. This never really mattered up until now, where it can interfere withVerifyNoOtherCalls.This solves one of two issues with the initial
VerifyNoOtherCallsimplementation, as tracked in #527 (comment).