SetupAllProperties: Defer property initialization
#550
Conversation
Let `SetupAllProperties` initialize set up properties only when they
are queried for the very first time. Doing this has two advantages:
1. There is no more immediate difference in execution speed between
`DefaultValue.Empty` and `DefaultValue.Mock`.
2. Type recursion / loops in the object graph are no longer an issue
(hence the changes to the unit tests). We no longer need to keep
track of already mocked types, so we can get rid of `GetInitial-
Value` and call `GetDefaultValue` directly.
| Assert.NotSame(mock.Object, mock.Object.Pong.Ping); | ||
|
|
||
| Assert.NotNull(mock.Object.Pong.Ping.Pong); | ||
| Assert.NotSame(mock.Object.Pong, mock.Object.Pong.Ping.Pong); | ||
| } |
There was a problem hiding this comment.
This unit test should guard against SetupAllProperties looping infinitely.
|
|
||
| mock.Setups.Add(new PropertyGetterMethodCall(mock, expression, getter, () => value)); | ||
| value = initialValue; | ||
| valueNotSet = false; |
There was a problem hiding this comment.
In theory, there's room for a race condition here. The uninitialized property could be queried simultaneously several times, or it could be queried while the setter is running, too. In practice, this might not matter much with regards to correctness, but it might cause some inefficiency because multiple initial values are produced when only one is required.
| if (mockedTypesStack.Contains(getter.ReturnType)) | ||
| { | ||
| // to deal with loops in the property graph | ||
| return mock.GetDefaultValue(getter, useAlternateProvider: DefaultValueProvider.Empty); |
There was a problem hiding this comment.
We no longer need to guard against "loops in the property graph" since SetupAllProperties only sets up the properties of the current level in the object's hierarchy. The setting up of deeper levels in the hierarchy must be triggered by querying a property.
Let
SetupAllPropertiesdefer initialization of set up properties to the point when they are queried for the very first time. Doing this has two advantages:There is no more immediate difference in execution speed between
DefaultValue.EmptyandDefaultValue.Mock. (Up until now,SetupAllPropertiescould be orders of magnitude slower when used with the latter default value mode.)Type recursion / loops in the object graph are no longer an issue (hence the changes to the unit tests). We no longer need to keep track of already mocked types, so we can get rid of
GetInitialValueand callGetDefaultValuedirectly.