Adopt assembly versioning scheme 'major.minor.0.0' #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale behind this is that we don't want changes in the patch
version to result in a different strong name; patches should be in-
place updates and shouldn't lead to version conflicts.
This will help reduce the need for assembly binding redirects.
For now, we only do 'major.minor.0.0' instead of 'major.0.0.0' (which
would be even better).
For the next release, we'll have to increase the minor version by 1
to rule out strange-looking binding redirects like these:
4.0.0.0 - 4.7.145.0 -> 4.0.0.0
4.0.0.0 - 4.7.145.0 -> 4.7.0.0
In both cases, the following will probably look less suspicious:
4.0.0.0 - 4.7.145.0 -> 4.8.0.0
Moq 5 will be able to safely make the switch to 'major.0.0.0'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale behind this is that we don't want changes in the patch version to result in a different strong name; patches should be in-place updates and shouldn't lead to version conflicts.
This will help reduce the need for assembly binding redirects.
For now, we only do 'major.minor.0.0' instead of 'major.0.0.0' (which would be even better).
For the next release, we'll have to increase the minor version by 1 to rule out strange-looking binding redirects like these:
In both cases, the following will probably look less suspicious:
Moq 5 will be able to safely make the switch to 'major.0.0.0'.
This closes #424.