Fix CallBase regression with explicitly implemented interface methods
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which shows that `CallBase` no longer works for explicitly implemented interface methods (which appear e. g. when `mock.As<TInterface>()` is used).
While we could just revert 5837c53, that would reintroduce a slow and hard to understand multi-line `if` condition. Let's instead rewrite the original conditions such that no superfluous checks are performed, and such that fast checks are performed first. (Notably, checking whether a type is an interface is faster than checking whether it is a class.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #557.