Matcher should always work with the whole expression, including Convert

[svick]

Without this change, the following code doesn't work correctly,
because the passed in long is compared against int.

interface IFoo
{
    string M(long l);
}

var mock = new Mock<IFoo>(MockBehavior.Strict);
mock.Setup(x => x.M(int.Parse("2"))).Returns("OK");
var result = mock.Object.M(2L);

This commit is based on a SO question that asked about this.

[svick]

Also, I'm not sure about the way it is decided whether the expression is evaluated lazily or not. Why should int.Parse("2") be lazy, but 0 + int.Parse("2") shouldn't?

[kzu]

I assume all tests pass with this change?

[kzu]

Also, we won't take a pull request for a fix that doesn't have a corresponding test repro that failed previously and now passes.

There is an IssueReportsFixture.cs file to keep those tests isolated.

Thanks!

[svick]

Yes, all unit tests pass for me.

And I have added unit test for this.