Ignore CallBase for members of additional interfaces #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CallBase` currently tries to call the base method implementation even for methods of additional interfaces (i. e. interfaces that were added to the proxy using `.As<TInterface>()` that the base class does not implement).
For explicitly implemented interfaces aka `.As<TInterface>()`, there are actually two subcases to consider wrt to `CallBase`: Reimplemented and additional interfaces. For the latter, the base class will never have an implementation, we need to add a check for that.
stakx
commented
Jan 25, 2018
| // Only call base method if it isn't an event accessor. | ||
| if (!method.LooksLikeEventAttach() && !method.LooksLikeEventDetach()) | ||
|
|
||
| if (mock.InheritedInterfaces.Contains(declaringType)) | ||
| { |
There was a problem hiding this comment.
It would be nice to add a Debug.Assert(!method.IsAbstract) here someday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #582. (See commit messages for details.)