Upgrade dependency on System.ValueTuple to version 4.4.0 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 4.3.0 doesn't properly support .NET Framework 4.7+, which already include the `ValueTuple` types and don't play well with a package that tries to re-define the same types. I've run some tests for the following target frameworks, and it seems that upgrading this package won't cause the kind of assembly version conflicts we had when upgrading System.Threading.Tasks.Extensions to 4.4.0: * netcoreapp1.0 * netcoreapp2.0 * net45 * net451 * net452 * net46 * net461 * net47 * net471 If versioning conflicts will pop up despite these tests, we'll have to multi-target Moq to `net47` as well and thereby blow up NuGet package size even more. Hopefully that won't be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #578.
(This change also bears the potential to retrigger problems similar to #566, which is why I tested this against different target frameworks—from
net45up tonet471and bothnetcoreapp1.0andnetcoreapp2.0. Visual Studio didn't report any assembly versioning conflicts, so I am reasonably confident that this is good to go.)