Add extension methods for IReturns to allow specifying return values exceptions on async methods in a synchronous way #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exceptions on async methods in a synchronous way.
|
Yes, as I said, the local diff didn't show the whitespace changes and I wouldn't have committed if it had. Let's see if I can find a way to revert this. As an alternative, could you just reject the change on the .csproj file and add IReturnsExtensions.cs then manually to the project ? |
|
Think I did it. |
|
Thanks for contributing this very useful feature @Blewzman . May I ask you to add a couple unit tests to ensure we have good coverage and no regresions in the future? These tests will also serve as the requirements for vNext ;) |
|
Sure. |
added 2 commits
November 15, 2013 10:12
|
Added some unit tests. |
|
Thanks @Blewzman for this feature! |
kzu
added a commit
that referenced
this pull request
Nov 19, 2013
Add extension methods for IReturns to allow specifying return values exceptions on async methods in a synchronous way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could use them so I wrote them. I hope you find them useful too, I can write those for more overloads if needed.
The changed formatting in the .csproj-file did not show up in my local diff, there's really just one line added (<Compile Include="Language\IReturnsExtensions.cs" />). Sorry for any inconveniences.
Daniel