Don't ignore non-public interfaces unconditionally #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mocking a type, Moq currently disregards all its base interfaces that are declared non-public. This was implemented in 6ad7103 to prevent DynamicProxy from choking on types inaccessible to it. This produces some collateral damage concerning `CallBase`: even when `CallBase == true` on the mock, base methods will not be called if they are declared in a non-public base interface. Simply excluding non-public base interfaces is too imprecise, because if there is a suitable `[assembly: InternalsVisibleTo]` custom attri- bute for DynamicProxy, then even a non-public interface might be accessible to DynamicProxy, and the error which the type exclusion supposedly protects against wouldn't occur in the first place. So instead of just excluding a non-public base interface, let's simply *ask* DynamicProxy whether it can access it or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #640. See commit message for details.
This PR does not include the regression test provided by @fgreinacher in that issue, because it would require a
[assembly: InternalsVisibleTo(…)]custom attribute in the test project, which in turn would break another test which explicitly requires that attribute to be absent.I don't think that creating an additional test project just for this one test is warranted.