Prevent false parameter count mismatch when using compiled methods with Returns
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods compiled from expression trees can have an additional first parameter of type `Sytem.Runtime.CompilerServices.Closure` which apparently captures all closed-over variables. This additional parameter can trigger a parameter count mismatch error in `MethodCallReturn.ValidateNumberOfCallbackParameters`. The test code is taken from: devlooped#652 (comment)
Apart from extension methods, there is (at least) one other case where the parameter count needs to be adjusted: static methods that have the first argument bound to `Delegate.Target`. Add a clause to check for this additional case.
stakx
force-pushed
the
parameter-count-mismatch
branch
2 times, most recently
from
70be99c
to
0af0bf7
Compare
stakx
force-pushed
the
parameter-count-mismatch
branch
from
0af0bf7
to
776bda6
Compare
stakx
force-pushed
the
parameter-count-mismatch
branch
from
776bda6
to
814add5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #652.