Move matcher selection logic into MatcherFactory
#661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this code move, all matcher selection / creation logic will be located in `MatcherFactory` only instead of being spread over `Method- Call`, too.
The logic that creates a matcher for a `params` array parameter would be better at home in the new `CreateMatcher` overload we created in the previous refactoring step. Moving it there allows us to get rid of that `isParams` parameter (i.e. to no longer have a special case) in the `CreateMatcher` method.
Move the argument matcher selection and out value gathering out of the ctor into dedicated methods to make the code more legible. Also rearrange assignments in both ctors to make it easier to see how they are different from one another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic for creating argument matchers from argument expressions has so far been spread over
MatcherFactoryand oneMethodCallctor. This refactoring places all of it where it belongs: intoMatcherFactory.This comes at the small additional cost of iterating over arguments a second time to identify
outparameters and gather their values, but the added code clarity and clearer responsibilities seem worth it.