Fixing #62 - Multithreaded test not working #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made the mutlithreaded tests work again by removing the locks around calls to external code, I have tested with all the repos I found for Google Code Issue 249 and they now pass or fail with OutOfMemoryExceptions has expected. I've added a test to ensure multithreading works. I have not found a test that reliably checks decent locking of the collections (without the mentioned out of memory problem, or taking a long time to run).
This was referenced Dec 11, 2013
Closed
|
I was trying to keep it targeting 3.5, which I believe is the plan. |
kzu
added a commit
that referenced
this pull request
Dec 16, 2013
Fixing #62 - Multithreaded test not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got some code which fixes Issues 47 and 62. I've done a bit of a refactor of the handling of the context in the Interceptor, this means we have one place that looks after access to the collections, and therefore one place for the locking. Hope the whitespace and line endings are all intact, took longer than the code changes to get it this neat!
None of the repos for google code issue 247 fail anymore, they all progress past the collection access problems and either slowly finish or hit out of memory exceptions that were already there.