De-deprecate [Matcher] attribute
#732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Dec 6, 2018
One of the tests being added here fails because a configured mock is used as an argument, which Moq executes to find out whether that argu- ment is a matcher. This is done by means of the `AmbientObserver`, which has the unfortunate side effect of disabling the argument mock's setups. Therefore, the expression `data.Id` in `data.Id.Value` will return `default(Guid?)` instead of the set up value, causing a null reference exception.
Until now, matchers based on `Match.Create<T>` worked just fine, even when they were not explicitly marked with a `[Matcher]` attribute (as an existing XML documentation comment claims is required.) This introduces a small breaking change by adding the requirement that *all* matchers must be marked as such using the `[Matcher]` attribute. This makes it possible for Moq to recognize `Match.Create<T>`-based matchers statically (i.e. just by inspecting an expression, but with- out executing it). This means improved runtime performance and allows us to fix the occasional bug.
stakx
force-pushed
the
matcherattribute
branch
from
8a652a7
to
ea268ba
Compare
stakx
commented
Dec 8, 2018
This was referenced Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #725 (though that is not the only reason behind this change).