Verify gets confused between the same generic and non-generic signature #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
suggested changes
Feb 16, 2019
There was a problem hiding this comment.
Looks great! 👍
Could you please add an entry to CHANGELOG.md (under the Unreleased → Fixed heading) that briefly describes this change? Then we'll be ready to merge!
#### Fixed
* `InvalidOperationException` when specifiying setup on mock with mock containing property of type `Nullable<T>` (@dav1dev, #725)
+* <short description of your bug fix> (@lepijohnny, #749)
## 4.10.1 (2018-12-03)
lepijohnny
changed the title
stakx
approved these changes
Feb 16, 2019
|
All good. Thank you for contributing! 👍 |
|
@stakx np, I will try to contribute more. You are doing great job guys 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #749. I also added a few tests to verify the derived generic parameters verification. It is already existing functionality in moq but the tests were missing. IMO it cannot be harmful anyway to add more tests.