Thorough aggregation of verification errors & more complete error messages #762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification using
mock.Verify[All]
has always been performed in a "recursive" manner (i.e. inner mocks were verified along with the outer / owning mock). However, in the case of failure, verification would often stop and only describe the first error in the message.This PR makes verification more thorough by aggregating verification errors at all levels:
For example, given this code:
you might now see such error message:
instead of the previous:
The trade-off here is obviously brevity vs. completeness. The latter probably makes more sense in an error message (IMO).