ActionObserver improved support for parameterized base class ctors & additional virtual calls
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wouldn't fail if it weren't for `ExpressionReconstructor` which totally ignores the possibility of running for objects that do not have a parameterless ctor.
...by allowing a later call to override earlier calls. (Note that this might still not be enough to fix the scenario where the final, import- ant method also performs virtual calls from its own method body.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test cases from two old issues, #430 and #432, which reveal some deficiencies in the current implementation of
ActionObserver:This should fix both of those. Closes #430, closes #432.