Make stringBuilder.AppendValueOf safer
#786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by only showing the first 10 items of enumerables for certain safe collection types (arrays and `List<T>`). It cannot be generally assum- ed that `IEnumerable` actually work. I cannot easily add the test case provided in devlooped#741 to the regression test suite as it relies on EF Core, and the test project already uses EF, so we'd likely have type conflicts if both of them are referenced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by only showing the first 10 items of enumerables for certain safe collection types (arrays and
List<T>). It cannot be generally assumed thatIEnumerableactually work.I cannot easily add the test case provided in #741 to the regression test suite as it relies on EF Core, and the test project already uses EF, so we'd likely have type conflicts if both of them are referenced.
Closes #741.