Add ToString() for fluent setup API objects #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
reviewed
Apr 17, 2019
stakx
changed the title
|
I sent you some messages on gitter, but wanted to mention them here in case you don't get notifications from gitter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Setupfails verification, it's helpful to have the exact expression that failed, rather than the defaultToString()representation of theSetupclass. To illustrate:What I'd like to see in the output message:
x => x.DoThings(null)What I actually get:
This PR fixes that by overriding the
ToString()methods and callingToStringFixed()on the expression that is being used. This allows for a nicely formatted string representation of the expression to be returned.Closes #810.