Prevent auto-stubbing failure due to inaccessible property accessors #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two groups of tests here: * Those that test `SetupAllProperties` (called either directly, or implicitly through `Mock.Of<T>`) followed by a property acces. This reflects `SetupAllProperties`' current implementation, which only sets up properties upon their first access (just-in-time). * Those that test `SetupAllProperties` itself, without any property access. Unsurprisingly, these currently pass, but the tests are still good to have in case we ever return `SetupAllProperties` to a ahead-of-time batch operation implementation.
ocoanet
pushed a commit
to ocoanet/moq4
that referenced
this pull request
Jun 10, 2019
…evlooped#847) 1. Add regression tests for lazy `SetupAllProperties` There are two groups of tests here: * Those that test `SetupAllProperties` (called either directly, or implicitly through `Mock.Of<T>`) followed by a property acces. This reflects `SetupAllProperties`' current implementation, which only sets up properties upon their first access (just-in-time). * Those that test `SetupAllProperties` itself, without any property access. Unsurprisingly, these currently pass, but the tests are still good to have in case we ever return `SetupAllProperties` to a ahead-of-time batch operation implementation. 2. Fix regression by checking accessor visibility 3. Update the changelog
ishimko
pushed a commit
to ishimko/moq4
that referenced
this pull request
Sep 2, 2019
…evlooped#847) 1. Add regression tests for lazy `SetupAllProperties` There are two groups of tests here: * Those that test `SetupAllProperties` (called either directly, or implicitly through `Mock.Of<T>`) followed by a property acces. This reflects `SetupAllProperties`' current implementation, which only sets up properties upon their first access (just-in-time). * Those that test `SetupAllProperties` itself, without any property access. Unsurprisingly, these currently pass, but the tests are still good to have in case we ever return `SetupAllProperties` to a ahead-of-time batch operation implementation. 2. Fix regression by checking accessor visibility 3. Update the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845.
/cc @Mexe13