Make return values of loose mock setups having no .Returns nor .CallBase more consistent
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a long-standing inconsistency in how Moq produces default
return values. Given a loose mock for a type which has some member
`TResult M()`:
* If there's no setup for `M`, the return value is determined by
`mock.CallBase` or, if it is not set, by `mock.DefaultValue-
[Provider]`.
* If there is a setup for `M`, which has either a `.Returns(...)` or
a `.CallBase()` clause, then the return value will be determined by
that.
* If there is a setup for `M`, but the setup has neither a
`.Returns(...)` nor a `.CallBase()` clause, then `default(T)` will
be returned.
The last one doesn't really fit in with the rest of how Moq handles
default values. While it may be a user mistake not to explicitly
specify the return value for a setup, it cannot hurt to make things
more consistent.
Better consistency in this case means that such "incomplete" setups
(3) will produce the same return value for M as (1).
stakx
force-pushed
the
setup-without-returns
branch
from
4199df2
to
c949425
Compare
ocoanet
pushed a commit
to ocoanet/moq4
that referenced
this pull request
Jun 10, 2019
This fixes a long-standing inconsistency in how Moq produces default
return values. Given a loose mock for a type which has some member
`TResult M()`:
* If there's no setup for `M`, the return value is determined by
`mock.CallBase` or, if it is not set, by `mock.DefaultValue-
[Provider]`.
* If there is a setup for `M`, which has either a `.Returns(...)` or
a `.CallBase()` clause, then the return value will be determined by
that.
* If there is a setup for `M`, but the setup has neither a
`.Returns(...)` nor a `.CallBase()` clause, then `default(T)` will
be returned.
The last one doesn't really fit in with the rest of how Moq handles
default values. While it may be a user mistake not to explicitly
specify the return value for a setup, it cannot hurt to make things
more consistent.
Better consistency in this case means that such "incomplete" setups
(3) will produce the same return value for M as (1).
ishimko
pushed a commit
to ishimko/moq4
that referenced
this pull request
Sep 2, 2019
This fixes a long-standing inconsistency in how Moq produces default
return values. Given a loose mock for a type which has some member
`TResult M()`:
* If there's no setup for `M`, the return value is determined by
`mock.CallBase` or, if it is not set, by `mock.DefaultValue-
[Provider]`.
* If there is a setup for `M`, which has either a `.Returns(...)` or
a `.CallBase()` clause, then the return value will be determined by
that.
* If there is a setup for `M`, but the setup has neither a
`.Returns(...)` nor a `.CallBase()` clause, then `default(T)` will
be returned.
The last one doesn't really fit in with the rest of how Moq handles
default values. While it may be a user mistake not to explicitly
specify the return value for a setup, it cannot hurt to make things
more consistent.
Better consistency in this case means that such "incomplete" setups
(3) will produce the same return value for M as (1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in commit message.
This also resolves #702.