Improve Error message given if protected method is setup with bad arguments #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne compatible argument types Adds the private static method Moq.Protected.ProtectedMock.ThrowIfMethodMissing which throws an ArgumentException similar to ThrowIfMemberMissing, but with a more informative message which includes the argument types included. Adds a string to the resources file for MissingMethod Updates applicable calls to ThrowIfMemberMissing to ThrowIfMethodMissing when it is obvious that the missing member is a method and not a property
Changed tests to check that the right string is being used in thrown messages. Also added a test which checks that an exception is thrown if incorrect types are supplied to a valid method.
For some reason VS2019 deciced that ResGen needed to turn everything in the resources files into spaces. I've manually formatted the files to put them back to how they were.
For some reason VS2019 deciced that ResGen needed to turn everything in the resources files into spaces. I've manually formatted the files to put them back to how they were.
stakx
suggested changes
Jul 14, 2019
Changed Error message and updated tests to reflect Changed to using .GetFormattedName from .ToString and updated tests to reflect Argument check is now against whether it is of type Expression rather than MethodCallExpression Removed typecast by adding variable assignment to if statement
stakx
approved these changes
Jul 14, 2019
|
Great work, thanks for your contribution! 🚀 |
ishimko
pushed a commit
to ishimko/moq4
that referenced
this pull request
Sep 2, 2019
…uments (devlooped#862) * Improved Error Messsage given if Protected method is supplied with none compatible argument types Adds the private static method Moq.Protected.ProtectedMock.ThrowIfMethodMissing which throws an ArgumentException similar to ThrowIfMemberMissing, but with a more informative message which includes the argument types included. Adds a string to the resources file for MissingMethod Updates applicable calls to ThrowIfMemberMissing to ThrowIfMethodMissing when it is obvious that the missing member is a method and not a property * Added Message checking to tests and added test Changed tests to check that the right string is being used in thrown messages. Also added a test which checks that an exception is thrown if incorrect types are supplied to a valid method. * Adapted Verify tests * Update CHANGELOG.md * Reverted Spaces to tabs in resources file For some reason VS2019 deciced that ResGen needed to turn everything in the resources files into spaces. I've manually formatted the files to put them back to how they were. * Reverted Spaces to tabs in resources file For some reason VS2019 deciced that ResGen needed to turn everything in the resources files into spaces. I've manually formatted the files to put them back to how they were. * Implimented requested changes Changed Error message and updated tests to reflect Changed to using .GetFormattedName from .ToString and updated tests to reflect Argument check is now against whether it is of type Expression rather than MethodCallExpression Removed typecast by adding variable assignment to if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #852