Merge cleaned-up ExpressionStringBuilder into StringBuilderExtensions
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... after ensuring that the (previous) `ExpressionStringBuilder` code file only contains `AppendExpression` methods at the top level (every- thing else is turned into local functions).
stakx
force-pushed
the
expressionstringbuilder
branch
from
a075865
to
d18d89f
Compare
ishimko
pushed a commit
to ishimko/moq4
that referenced
this pull request
Sep 2, 2019
…ons` (devlooped#882) * Convert `ExpressionStringBuilder` to extension methods * Chain `StringBuilder` operations * General-purpose `AppendCommaSeparated` method reduces code duplication * Inline a few one-line methods * Simplify enclosed comma-separated lists code pattern * Refactor more existing code to use `AppendCommaSeparated` * Use more regular method names * Merge into `StringBuilderExtensions` ... after ensuring that the (previous) `ExpressionStringBuilder` code file only contains `AppendExpression` methods at the top level (every- thing else is turned into local functions). * Inline event add/remove formatting code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by turning its methods into a bunch of
stringBuilder.AppendExpression(expression)methods, of which only one is publicly exposed. This PR is a fairly large refactoring, so it's done in quite a few commits.