Fix type cast bug in ParamArrayMatcher
#912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `canCastValueToT` check added in the previous commit is extracted and reused in `Match.SetupEvaluatedSuccessfully` (where the same type of cast happens) as an assertion, that assertion will trigger. There's a bug in `ParamArrayMatcher`.
The assertion added in the last commit can be more easily understood if the relationship between these two methods is made more explicit. Let's do so via assertions.
stakx
force-pushed
the
paramarraymatcher
branch
from
ebafd56
to
77f939e
Compare
ishimko
pushed a commit
to ishimko/moq4
that referenced
this pull request
Sep 2, 2019
* `Capture.In` does not work in `params` parameter If `canCastValueToT` check added in the previous commit is extracted and reused in `Match.SetupEvaluatedSuccessfully` (where the same type of cast happens) as an assertion, that assertion will trigger. There's a bug in `ParamArrayMatcher`. * Fix bug by fanning out array into its elements * Document relationship between `Matches`, `SetupEvaluatedSuccessfully` The assertion added in the last commit can be more easily understood if the relationship between these two methods is made more explicit. Let's do so via even more assertions. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.