Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve precision of event accessor method resolution #914

Merged
merged 4 commits into from
Aug 31, 2019

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Aug 31, 2019

With this PR, Moq starts identifying events by their full EventInfo instead of just by their name.

This was originally planned for version 4.13.1, but since we're adding functionality to setup & verify event subscription / unsubscription in 4.13.0, it will become possible (and more likely) that users work with events more often. Therefore event identification should be reasonably accurate, or we'll just receive unnecessary bug reports.

Fixes #893.

@stakx stakx added this to the 4.13.0 milestone Aug 31, 2019
@stakx stakx merged commit bf45f80 into devlooped:master Aug 31, 2019
@stakx stakx deleted the events branch August 31, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moq does not distinguish between distinct events if they have the same name
1 participant