Let InnerMockSetup (i.e. internal setups for cached return values) match generic args exactly instead of by assignment compatibility.
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this fixes the regression documented in the previous commit, it might be an insufficent solution in general. Perhaps it would be more correct to take co-/contra-variance into account and select a compari- son mode per generic argument depending on whether it appears in a input and/or output position?
|
Going to merge this despite my reservations that I mentioned above. In the worst case, the change being made here means some additional "cache" misses, i.e. Moq will at worst produce new return values instead of returning the previous one. Other parts of Moq shouldn't be affected by this change. |
|
@stakx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #932.
As mentioned in one commit message, I am not convinced this is a 100% correct bug fix... it could even introduce new problems. It would benefit from some additional thinking about how Moq should generally handle co-/contravariance when matching setups for generic methods.
/cc @BrunoJuchli