Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal verification API more generic than Verify(), VerifyAll() #983

Merged
merged 4 commits into from
Mar 28, 2020

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Mar 28, 2020

This is a prerequisite to #976, as it gets the setup verification API ready for publication.

Besides simplifying existing code, it also opens doors to new future forms of verification besides just mock.Verify() and mock.VerifyAll()—think mock.Verify(setup => setup.State.Contains(<some tag>).

/cc @ashmind

@stakx stakx added this to the 4.14.0 milestone Mar 28, 2020
@stakx stakx force-pushed the setup-verification branch 2 times, most recently from 5295af8 to 411629e Compare March 28, 2020 14:21
@stakx stakx changed the title Make verification API more general than Verify(), VerifyAll() Make verification API more generic than Verify(), VerifyAll() Mar 28, 2020
@stakx stakx merged commit 634daa3 into devlooped:master Mar 28, 2020
@stakx stakx deleted the setup-verification branch March 28, 2020 14:28
@stakx stakx changed the title Make verification API more generic than Verify(), VerifyAll() Make internal verification API more generic than Verify(), VerifyAll() Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant