Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Func<IInvocation,> callback with Returns #992

Merged
merged 2 commits into from
Apr 5, 2020

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Apr 5, 2020

Closes #953.

These tests target existing logic in `MethodCall.SetReturnsCallback`
which happens to be too strict to work in the situations for which it
was defined.

(Users should still prefer `new InvocationFunc(invocation => ...)`
usage instead of just `(IInvocation invocation) => ...` because it
works in all situations whereas the latter does not; but since we al-
ready have logic for the latter in place, let's make sure it works.)
@stakx stakx added this to the 4.14.0 milestone Apr 5, 2020
@stakx stakx merged commit 9c00c4d into devlooped:master Apr 5, 2020
@stakx stakx deleted the relax-returns-callback-validation branch April 5, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback and Returns: Allow callback parameters to have type object where a type matcher was used
1 participant