New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate RepositoryBranch when building #2

Closed

kzu opened this issue Dec 17, 2020 · 0 comments

Labels

Member

kzu commented Dec 17, 2020

Since RepositoryBranch isn't populated by SourceLink, we should pass it in from the build scripts.

This is as trivial as -p:RepositoryBranch=${GITHUB_REF#refs/*/}

The text was updated successfully, but these errors were encountered:

kzu added the enhancement label

kzu closed this as completed in

e6a51e4

kzu added a commit to devlooped/GitInfo that referenced this issue


          Set default GitBranch from CI env variables

19b99bf

Virtually all CI systems provide environment variables containing the branch from the underlying source control.

This is already in use in:
https://github.com/dotnet/reproducible-builds/pull/
devlooped/oss#2
devlooped/nugetizer#57
devlooped/ThisAssembly#69

We should also bring in the same defaults here. Hopefully this will one day be part of SourceLink.

kzu mentioned this issue

Set default GitBranch from CI env variables devlooped/GitInfo#365

Merged

kzu added a commit to devlooped/GitInfo that referenced this issue


          Set default GitBranch from CI env variables

1e0e2f4

Virtually all CI systems provide environment variables containing the branch from the underlying source control.

This is already in use in:
https://github.com/dotnet/reproducible-builds/pull/
devlooped/oss#2
devlooped/nugetizer#57
devlooped/ThisAssembly#69

We should also bring in the same defaults here. Hopefully this will one day be part of SourceLink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment