Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects the libraries panic behaviors #7

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

benjivesterby
Copy link
Member

This library will no longer swallow panics with this change

Closes GH-5

This library will no longer swallow panics with this change

Closes GH-5
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #7 (9041cd4) into main (5aa6160) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          207       200    -7     
=========================================
- Hits           207       200    -7     
Impacted Files Coverage Δ
scaler.go 100.00% <ø> (ø)
stream.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa6160...9041cd4. Read the comment docs.

@benjivesterby benjivesterby merged commit 20b5ccf into main Mar 22, 2022
@benjivesterby benjivesterby deleted the GH-5-recover branch March 22, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Silently swallowing panics is bad
1 participant