Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#346 Version variable ignored by maven archetype #353

Merged
merged 13 commits into from
Mar 15, 2021
Merged

#346 Version variable ignored by maven archetype #353

merged 13 commits into from
Mar 15, 2021

Conversation

sujith-mn
Copy link
Member

@sujith-mn sujith-mn commented Feb 25, 2021

Addresses #346

@sujith-mn sujith-mn requested a review from hohwille February 25, 2021 04:20
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sujith-mn thanks for this PR.
I will still have to rework the maven.config but this is a good improvement. 👍
We could also follow @maybeec suggestion and simply remove and ignore changelist to make it simply. I will change devonfw-ide release commandlet to also support this.

@hohwille hohwille added enhancement New feature or request SCM Software-configuration-management (maven, travis, etc.) template maven-archetype to create new application. labels Mar 15, 2021
@hohwille hohwille added this to the release:2020.12.003 milestone Mar 15, 2021
@hohwille hohwille merged commit 8865b39 into devonfw:master Mar 15, 2021
@hohwille hohwille modified the milestones: release:2020.12.003, release:2021.04.001 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SCM Software-configuration-management (maven, travis, etc.) template maven-archetype to create new application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version variable ignored by maven archetype ci-friendly-maven also for archetype
2 participants