Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup of devon ide create hangs #1068

Closed
hohwille opened this issue Mar 13, 2023 · 2 comments · Fixed by #1069
Closed

setup of devon ide create hangs #1068

hohwille opened this issue Mar 13, 2023 · 2 comments · Fixed by #1069
Assignees
Labels
blocker severe bug that blocks users in their daily work and has to be fixed asap bug Something isn't working windows specific for Microsoft Windows OS

Comments

@hohwille
Copy link
Member

hohwille commented Mar 13, 2023

$ devon ide create test
You are not inside a devonfw-ide installation: /d/projects

*** Software Update of devonfw-ide-scripts ***
Updating test/ from https://repo.maven.apache.org/maven2/com/devonfw/tools/ide/devonfw-ide-scripts
Trying to determine the latest available version from https://repo.maven.apache.org/maven2/com/devonfw/tools/ide/devonfw-ide-scripts/maven-metadata.xml
Success: run command mkdir
Starting installation of devonfw-ide-scripts in version 2023.02.001 to test/
Trying to download devonfw-ide-scripts-2023.02.001.tar.gz from https://repo.maven.apache.org/maven2/com/devonfw/tools/ide/devonfw-ide-scripts/2023.02.001/devonfw-ide-scripts-2023.02.001.tar.gz
Artifact already exists at /c/Users/hohwille/Downloads/devonfw-ide/devonfw-ide-scripts-2023.02.001.tar.gz
To force update please delete the file and run again.
Success: run command tar
Successfully extracted archive devonfw-ide-scripts-2023.02.001.tar.gz to /d/projects/mmm/updates/extracted
Creating backup by moving existing test/ to /d/projects/mmm/updates/backups/23-03-13
Success: run command mv
Successfully installed devonfw-ide-scripts
Setting up your devonfw-ide in /d/projects/test
Creating main workspace directory

At this point devonfw-ide hangs forever (infinity loop).

Setting up your devonfw-ide in /d/projects/test

This looks correct but I am slightly confused by things like this:

Creating backup by moving existing test/ to /d/projects/mmm/updates/backups/23-03-13

He really created such folder that is actually empty. That is also a bug but not really a very relevant one.

Was this feature #819 somehow based on the bug #1066 as now broke as #1066 is fixed? I assume not because #819 was released before the bug #1066 was introduced. However I had tested this #819 feature several times and now ran into this bug for the first time. Can someone reproduce this bug and confirm? Nope - not related.

I cancelled the process after hours with [Ctrl][c].
Now, I entered the folder and saw that the latest devonfw-ide scripts have been properly extracted.
As I was in git-bash, I simply called this:

./scripts/devon ide setup

This is causing the same result with the hanging process. However, it works when I instead type this:

$ ./scripts/devon ide update
Missing your settings at /d/projects/teavm/settings and no SETTINGS_URL is defined.
Further details can be found here:
https://github.com/devonfw/ide/blob/master/documentation/settings.asciidoc
Please contact the technical lead of your project to get the SETTINGS_URL for your project.
In case you just want to test devonfw-ide you may simply hit return to install default settings.

Settings URL [https://github.com/devonfw/ide-settings.git]:
Success: run command git

*** Setting up mvn ***
Success: run command git
Success: run command mkdir
Starting installation of java in version 19_36 to /d/projects/teavm/software/java
Trying to download java-19_36-windows.zip from https://github.com/adoptium/temurin19-binaries/releases/download/jdk-19%2B36/OpenJDK19U-jdk_x64_windows_hotspot_19_36.zip
Artifact already exists at /c/Users/hohwille/Downloads/devonfw-ide/java-19_36-windows.zip
To force update please delete the file and run again.
Success: run command unzip
...

So it seems that we have changed something in ide commandlet recently related to setup causing this endless loop or whatever blockage.

@hohwille hohwille added the bug Something isn't working label Mar 13, 2023
@hohwille
Copy link
Member Author

Error is related to PR #1067:
As you can see in the diff of the PR the version of devon.bat before ended after printing the version. Now script code was moved after that and is now executed after printing the version. This gives the following result:

$ devon.bat -v
2023.02.001

SUCCESS: Specified value was saved.
"ATTENTION:"
"Your user PATH environment variable has not been previously set."
"You may need to log-off and log-in again so your PATH changes are properly applied."
"Otherwise you may get errors that devon command has not been found."
Press any key to continue . . .

As a result that entire text is considered as version and doVersionCompate ends up in an infinity loop since it can not handle newlines and similar garbage. Again another small bug somewhere else reveal by the actual bug.

@hohwille hohwille added this to the release:2023.03.001 milestone Mar 13, 2023
hohwille added a commit to hohwille/ide that referenced this issue Mar 13, 2023
@hohwille hohwille linked a pull request Mar 13, 2023 that will close this issue
@hohwille hohwille added blocker severe bug that blocks users in their daily work and has to be fixed asap windows specific for Microsoft Windows OS labels Mar 13, 2023
@hohwille hohwille changed the title devon ide create hangs setup or devon ide create hangs Mar 13, 2023
hohwille added a commit to hohwille/ide that referenced this issue Mar 13, 2023
hohwille added a commit that referenced this issue Mar 13, 2023
@hohwille
Copy link
Member Author

Fun fact: We automated the release with github actions that are now running on linux.
With the old process the the release was done on my local windows machine where it would have got stuck in this step as I retested:

Running test #2: test-setup

@hohwille hohwille self-assigned this Mar 13, 2023
@hohwille hohwille changed the title setup or devon ide create hangs setup of devon ide create hangs Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker severe bug that blocks users in their daily work and has to be fixed asap bug Something isn't working windows specific for Microsoft Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant