Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devonfw/ide#414: eclipse plugin tracker #568

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

tobka777
Copy link
Member

fixes #414

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobka777 Thanks for your PR. You understood the task well, found the right spots to change and created a nice solution. 👍
I have added some small review comments for improvement. Please update your PR accordingly and we can even include this into the release that will be created soon (maybe on Friday depending on availability of cobigen release).

scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/eclipse Outdated Show resolved Hide resolved
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobka777 thanks for taking up all the review comments and updating this PR. All perfect now and ready for merge 👍

@hohwille hohwille merged commit b092a64 into devonfw:master Apr 29, 2021
@hohwille hohwille added this to the release:2021.04.001 milestone Apr 29, 2021
@hohwille hohwille added eclipse related to Eclipse IDE enhancement New feature or request plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) labels Apr 29, 2021
@tobka777 tobka777 deleted the feature/414-eclipse-plugin-tracker branch May 19, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eclipse related to Eclipse IDE enhancement New feature or request plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eclipse Plugin Installation not always reliable
2 participants