Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#637 Terraform integration #709

Merged
merged 17 commits into from
Mar 24, 2022
Merged

#637 Terraform integration #709

merged 17 commits into from
Mar 24, 2022

Conversation

CREITZ25
Copy link
Member

Files to integrate terraform installation into devonfw IDE

@CREITZ25
#637 Terraform integration
f351aa4 
Files to integrate terraform installation into devonfw IDE
@CREITZ25
fixing error in spellchecker
36d9e25 
I will use $(...) instead of `...`
@CREITZ25
Update LICENSE.asciidoc
ddbf5ef 
Add Licence for Terraform
tobka777
tobka777 reviewed Feb 24, 2022
View reviewed changes
Copy link
Member

@tobka777 tobka777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the integration. Looks quite good already. I have noted a few small things. I think we should call doSetup in doRun like it was done with the other tools.

scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
@CREITZ25
Correct last errors
113ec72 
Correct last errors
@CREITZ25
Update LICENSE.asciidoc
0fde724 
Correction of the first link from kubernetes to terraform
hohwille
hohwille requested changes Mar 7, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 excellent work 👍

I have two last tiny review comments added. Please have a look and update. Then I will merge. Thanks.

scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Mar 7, 2022
CREITZ25 and others added 2 commits March 8, 2022 12:59
@CREITZ25
#637 Terraform integration
cec1d9f 
#637 Terraform integration
delete doIsTerraformInstalled function
@hohwille
Merge branch 'master' into feature/terraform
fca4d85
@hohwille
Copy link
Member

hohwille commented Mar 8, 2022

The build failed due to shellcheck:

In scripts/command/terraform line 25:
  if $(command -v terraform &> /dev/null) 
     ^-- SC2091: Remove surrounding $() to avoid executing output.

@CREITZ25
#637 Terraform integration
84651b0 
#637 Terraform integration
remove $()
CREITZ25
CREITZ25 commented Mar 21, 2022
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check again

scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/terraform Outdated Show resolved Hide resolved
CREITZ25 and others added 4 commits March 22, 2022 13:06
@CREITZ25
#709 Terraform Integration
b8a3688 
#709 Terraform Integration - print version
@CREITZ25
#637 Terraform Integration
b9dd8ae 
#637 Terraform Integration delete wrong if case
@CREITZ25
#637 Terraform Integration
78cae90 
#637 Terraform Integration TERRAFORM_HOME ergänzt
@hohwille
final polishing
9a1c17e
hohwille
hohwille approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 all perfect, thanks 👍

@hohwille hohwille added this to the release:2021.12.006 milestone Mar 24, 2022
@hohwille
Copy link
Member

With my last commit the build should be fixed now.

@hohwille hohwille merged commit ae237df into master Mar 24, 2022
@hohwille hohwille linked an issue Mar 24, 2022 that may be closed by this pull request
Terraform integration #637
Closed
10 tasks
@hohwille hohwille mentioned this pull request Mar 24, 2022
Closed
10 tasks
@CREITZ25 CREITZ25 deleted the feature/terraform branch June 9, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobka777 tobka777 tobka777 left review comments

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2022.04.001
Development

Successfully merging this pull request may close these issues.

Terraform integration
4 participants
@CREITZ25 @hohwille @tobka777 @maybeec