P9 #147
Open
P9 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets up the repo to perform code coverage with the `check` target on gradle. We're also upgrading to gradle to 3.4 which adds support for `jacocoTestReport` and `jacocoTestCoverageVerification` targets. We comment out the settings.gradle to just have a focus in the exercise for the monolith. We might uncomment that again later.
Setup plugins for performing code coverage
This adds a variable called COVERAGE for test coverage so that we can build some peer exercises for working with environment variables that control our build.
variablize the coverage testing
verification was missing from some sub projects
Not all the sub-projects are ready for full coverage testing, so we're reducing the testing point lower than the highest testing point for other projects so that they always pass in favor of projects that are ready. If we test below that limit, then testing coverage can apply for these sub projects.
We need some sub-projects to have WIP coverage testing
fix service user with WIP
This tunes our coverage range to use the test cases that have the best coverage, but still enable lower coverage for other sub projects.
Tune coverage ranges
This is a bump for gradel wrapper to see if we can fix the java 9.0.1 build errors.
bumping to gradel 4.3.1 wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test