Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Images not resolving in early static events. #665

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Images not resolving in early static events. #665

merged 1 commit into from
Oct 15, 2018

Conversation

chriscoffee
Copy link
Member

@chriscoffee chriscoffee commented Oct 7, 2018

This should fix #662

I noticed that https://www.devopsdays.org/events/2016-minneapolis/speakers/ had broken images. I looked into it, and it appears that we don't have images loading correctly in archived events that have been built for the live site. If I check locally, it still doesn't work because www.devopsdays.org is baked into the static files. If I look directly at the URL of a speaker image locally (not a link to it), it does still exist and redirect to where it lives in /static: http://localhost:1313/events/2016-minneapolis/speakers/aj-bowen.jpg

Looks like the gulp task which copied old images from /public/events/2016-minneapolis/speakers/ wasn't copying them across to /dist/events/2016/minneapolis/speakers/ causing the images to be broken.

I spun up an example of the 'fixed' example of this here: https://mystifying-goodall-173afa.netlify.com/events/2016-minneapolis/speakers/aj-bowen.jpg using the same problematic image.


This change is Reviewable

It looks like the images that were in these files weren't being copied
across from /public -> /dist when ./netlify-production.sh ran the gulp
task to copy stuff across.

Signed-off-by: Chris M <millscj01@gmail.com>
@bridgetkromhout
Copy link
Contributor

Thanks, Chris! I know @mattstratton is planning a release soon - likely this is something he'll want to consider getting in!

@mattstratton
Copy link
Member

I'll merge this in - we have to "manually" make this change into devopsdays-web since the gulp stuff is part of the repo and not part of the theme, but I think I can copy-paste it just fine :)

@mattstratton mattstratton merged commit d719f75 into devopsdays:master Oct 15, 2018
mattstratton added a commit to devopsdays/devopsdays-web that referenced this pull request Oct 15, 2018
mattstratton added a commit to devopsdays/devopsdays-web that referenced this pull request Oct 15, 2018
@chriscoffee chriscoffee deleted the gulp-old-images branch October 18, 2018 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

images not resolving in static events
3 participants