Rework the past and future bottom footers #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note two bugs this introduces that will need to be fixed later: 1. The "past" footer is still data-driven. This means that we need to migrate the past events to the new format. Or we hard-code them into the template and have to manually move events after they occur. As this entire UX in the footer is being revamped, I think we will do the latter. 2. The year "2016" is hard-coded into the headline on the "future.html" partial for now :)
benjohnson77
pushed a commit
to benjohnson77/devopsdays-web
that referenced
this pull request
May 22, 2016
…ttom-footer Rework the past and future bottom footers Former-commit-id: 474373d
yvovandoorn
pushed a commit
that referenced
this pull request
May 22, 2016
Rework the past and future bottom footers
yvovandoorn
pushed a commit
that referenced
this pull request
May 22, 2016
Rework the past and future bottom footers Former-commit-id: 474373d
yvovandoorn
pushed a commit
that referenced
this pull request
May 22, 2016
Rework the past and future bottom footers
yvovandoorn
pushed a commit
that referenced
this pull request
May 29, 2016
Rework the past and future bottom footers Former-commit-id: 474373d
yvovandoorn
pushed a commit
that referenced
this pull request
May 29, 2016
Rework the past and future bottom footers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note two bugs this introduces that will need to be fixed later: