Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZRH-2017] add vimeo videos to speakers #2471

Merged
merged 6 commits into from
May 30, 2017
Merged

[ZRH-2017] add vimeo videos to speakers #2471

merged 6 commits into from
May 30, 2017

Conversation

Roderick-Jonsson
Copy link
Contributor

Added the vimeo links to the speakers but it seems that they don't show up on the speaker page. Can someone comfirm this problem?

@bridgetkromhout
Copy link
Collaborator

Thanks for reporting this bug. When my fix in devopsdays/devopsdays-theme#543 is merged and a new version released, this PR will be almost right except that since this needs embed URLs you'll want to just have the ID number, not the full URL.

For example:
vimeo = "219025568"

Also, you can just use speakerdeck now:

speakerdeck = "https://speakerdeck.com/dodzh/d1-3-alvaro-videla-what-we-talk-about-when-we-talk-about-distributed-systems"

You don't need this kind of link now that speakerdeck embeds work:

slides = "https://speakerdeck.com/dodzh/d1-3-alvaro-videla-what-we-talk-about-when-we-talk-about-distributed-systems"

@Roderick-Jonsson
Copy link
Contributor Author

Thank you @bridgetkromhout !

@mattstratton
Copy link
Member

As soon as #2473 is merged, this should start working, so I'll merge it after the theme update passes the release.

@mattstratton mattstratton merged commit 0234722 into devopsdays:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants