Improve RepoList test coverage (#90)

* Improve RepoList test coverage

To ensure we don't see bug #87 again.

Also added a few other misc. test improvements.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

tests/data/cleanup.yaml

@@ -7,8 +7,9 @@ artifactory-cleanup:
   policies:
     - name: Remove all files from repo-name-here older then 7 days
       rules:
-        - rule: Repo
-          name: "repo-name-here"
+        - rule: RepoList
+          repos:
+            - "repo-name-here"
         - rule: DeleteOlderThan
           days: 7
 

tests/test_cli.py

@@ -11,6 +11,9 @@ def test_help(capsys):
         ],
         exit=False,
     )
+    stdout, stderr = capsys.readouterr()
+    assert "Usage:" in stdout
+    assert not stderr
     assert code == 0
 
 
@@ -29,6 +32,7 @@ def test_dry_mode(capsys, shared_datadir, requests_mock):
     stdout, stderr = capsys.readouterr()
     assert code == 0, stdout
     assert "Verbose MODE" in stdout
+    assert "Destroy MODE" not in stdout
     assert (
         "DEBUG - we would delete 'repo-name-here/path/to/file/filename1.json'" in stdout
     )
@@ -54,6 +58,7 @@ def test_destroy(capsys, shared_datadir, requests_mock):
     stdout, stderr = capsys.readouterr()
     assert code == 0, stdout
     assert "Destroy MODE" in stdout
+    assert "Verbose MODE" not in stdout
 
     assert (
         requests_mock.call_count == 6

tests/test_rules_repo.py

@@ -14,3 +14,11 @@ def test_RepoList():
             ]
         }
     ]
+    session = "session"
+    today = "today"
+    rule.init(session, today, "arg1", "arg2", "arg3", abc=123)
+    assert rule.session is None
+    assert rule.today is None
+    for repo in rule.repos:
+        assert repo.session == session
+        assert repo.today == today