version 1.0.0 - YAML support, new and stable Rule API

[allburov]

• fix Stabilize and document API for Rules #33
• fix Proposal: YAML format for rules #54
• fix Multiple paths not working #68
• fix Can this project support custom sorting？ #53
• fix The behaviour of KeepLatestNVersionImagesByProperty is unclear and possibly incorrect #60
• Support JCR Can I use this tools on JCR ? #59

[allburov]

@Pro @zhan9san Hi!
Could you have a look at the changes for YAML configuration?
Readable readme is here: https://github.com/devopshq/artifactory-cleanup/tree/yaml-configuration

If you have a time - could you run the new version against your configuration files one time to make sure it works the same way it used to work.

python3 -mpip install git+https://github.com/devopshq/artifactory-cleanup.git@yaml-configuration

Suggestions and notes are welcome!

[donhui]

@allburov
I have tested cleanup docker images, it works for me.

[zhan9san]

@allburov
If this is not urgent, I'll test it next week.

[Pro]

Will not have time to test it. Just a quick note from my side:

Since this is a new major release, you should use the chance to get rid of old/deprecated stuff.
IMHO backward compatibility does not need to be there for major version bumps.

[allburov]

@donhui thank you man!
@zhan9san sure, waiting for your feedback!

@Pro good point!
Do you mean to remove these features or I missed something?

1. Load rules from python file
2. CLI parameters artifactory-server, user, password
3. under_score names for Rules

[Pro]

@donhui thank you man! @zhan9san sure, waiting for your feedback!

@Pro good point! Do you mean to remove these features or I missed something?

1. Load rules from python file
2. CLI parameters artifactory-server, user, password
3. under_score names for Rules

Mainly thought about removing old/deprecated features, like the ones you already mention. Did not look in detail at all the changes.

[allburov]

@Pro great, I agree with you, it was so annoying to keep them in mind when changing code... I'll remove all old features!

[donhui]

@allburov
I have a suggestion.
When deleting an artifact, can we print the size of each artifact to be deleted into the log?
Or, can the logs printed when deleting artifacts be expanded? So that users can customize the log.
Thanks.

[allburov]

@donhui

can we print the size of each artifact

Added it!

deleting artifacts be expanded?

I was thinking about adding API for cleanuppolicy too - to handle some special case like cleaning docker or conan repositories. But for now it's too rare cases, so we can handle them in configuration just by using current rules.